Fix _plugin_escalade_rules_only on group assignment - #489
Open
Lainow wants to merge 2 commits into
Open
Conversation
The flag was only read by pre_item_update() on Ticket, where escalade sets it on its own internal update to avoid recursion. Callers that assign a technician group themselves (other plugins, scripts) had no way to opt out: a Group_Ticket::add() carrying the flag still went through processAfterAddGroup(), which unassigned the technician when remove_tech is on, forced ticket_last_status and recorded an escalation history entry. Read the flag in both Group_Ticket hooks so it means the same thing there: escalade skips its logic entirely for that assignment.
3 tasks
RomainLvr
approved these changes
Aug 25, 2026
Rom1-B
approved these changes
Aug 25, 2026
stonebuzz
approved these changes
Aug 26, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
Linkend to : Improve compatibility with the Escalade plugin moreoptions#9
Here is a brief description of what this PR does
The flag was only read by pre_item_update() on Ticket, where escalade sets it on its own internal update to avoid recursion. Callers that assign a technician group themselves (other plugins, scripts) had no way to opt out: a Group_Ticket::add() carrying the flag still went through processAfterAddGroup(), which unassigned the technician when remove_tech is on, forced ticket_last_status and recorded an escalation history entry.
Read the flag in both Group_Ticket hooks so it means the same thing there: escalade skips its logic entirely for that assignment.
Screenshots (if appropriate):